-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add alternate location for upper bounds in serverless #134418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternate location for upper bounds in serverless #134418
Conversation
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
Pinging @elastic/es-core-infra (Team:Core/Infra) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small nit, otherwise LGTM.
if (getAlternateUpperBoundFile().isPresent()) { | ||
Path altUpperBoundPath = getAlternateUpperBoundFile().get().getAsFile().toPath(); | ||
String contents = Files.readString(altUpperBoundPath, StandardCharsets.UTF_8); | ||
var altUpperBound = TransportVersionUpperBound.fromString(altUpperBoundPath, contents); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we agree on when we do and don't use var
. I just find it really odd to mix explicit type declarations and var
on literally consecutive lines of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My rule of thumb is I only use it in these cases:
- if the type is obvious, eg the rhs has
new
or is an obvious factory method like here - if the line is incredibly long because of generic types
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
💔 Backport failed
You can use sqren/backport to manually backport by running |
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
elastic#134548) In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
elastic#134548) In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consule when generating a new transport version.
In serverless new transport versions are based on the greater of the largest serverless transport version, or the largest in server. This commit adds configuration to the generate task which allows specifying the upper bound file from server to consult when generating a new transport version.